fix: format table viz totals #2693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeRego
added
🐛 bug
owlas
requested a deployment
to
fix/format-table-viz-totals - jaffle_db PR #2693
Render
Abandoned
✅ Deploy Preview for peaceful-bassi-cbf284 canceled.
|
|
Fixes #2695 |
|
Code looks good, @12ian34 would you like to test this on render before we merge? otherwise I can do it . Makes sure it doesn't break anything else (test edge cases, different fields, etc) . |
ZeRego
removed
🐛 bug
ZeRego
force-pushed
the
fix/format-table-viz-totals
branch
from
308053e
to
811d136
Compare
owlas
temporarily deployed
to
fix/format-table-viz-totals - lightdash PR #2693
Render
Destroyed
github-actions bot
pushed a commit
that referenced
this pull request
Jul 13, 2022
# [0.181.0](0.180.1...0.181.0) (2022-07-13) ### Bug Fixes * edit table calculation ([#2696](#2696)) ([eb0871d](eb0871d)) * filter from table ([#2682](#2682)) ([c2e79bb](c2e79bb)) * format table viz totals ([#2693](#2693)) ([bcd81d7](bcd81d7)) ### Features * grouping dimensions and metrics ([#2680](#2680)) ([10b6740](10b6740))
|
🎉 This PR is included in version 0.181.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Totals in the table viz weren't formatted like the values in the column.
Closes: #2695
Description: