fix: default value for time interval filters #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeRego
added
🐛 bug
ZeRego
changed the title
rephus
approved these changes
Jul 6, 2022
@rephus correct, your fix was for applying the date values from the table into the filter. iirc it was always applying a new Date() before your fix. |
ZeRego
force-pushed
the
fix/default-value-for-time-interval-filters
branch
from
07e0bd0
to
bea123d
Compare
owlas
requested a deployment
to
fix/default-value-for-time-interval-filters - jaffle_db PR #2636
Render
Abandoned
✅ Deploy Preview for peaceful-bassi-cbf284 canceled.
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
## [0.171.5](0.171.4...0.171.5) (2022-07-06) ### Bug Fixes * default value for time interval filters ([#2636](#2636)) ([e6ab4d1](e6ab4d1))
|
🎉 This PR is included in version 0.171.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Before the default values weren't for the start of the week/month/year until the input was changed.
Lightdash - bug default value for time interval filters - Watch Video
After:
Lightdash - fix default value for time interval filters - Watch Video